Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I disbelieve. Which would you prefer to read to get the output of a system call?

  `your system call and args`

  subprocess.Popen(['your', 'system', 'call', 'and', 'args'], stdout=subprocess.PIPE).communicate()[0]
The former is the traditional syntax supported in various shells, Perl, and Ruby. The latter is what you need if you want your code to run in Python 2.6.

And this is before we get into the fact that the minutia of syntax and layout is only a minor factor in the maintainability of large projects.



Python still has (even in 3.2) os.system, which is the equivalent of the backticks from perl/shell. The subprocess module is preferred because you have more control and options than simply deferring to the C library's system() call.


Python still has (even in 3.2) os.system, which is the equivalent of the backticks from perl/shell.

Sorry, but you're wrong. The os.system call is the equivalent of Perl's system call. It runs an external command and gives you a return code, but does not give you the text generated by said system call. The officially recommended (as of Python 2.6) way to get said text is what I wrote.

The deprecated but possibly still working solution is to use os.popen. That is cleaner for this common use case, but I chose to stick to the the officially recommended solution instead.

Eventually the Python folks realized that the blessed One True Way to do it was actually pretty horrible, and so they added subprocess.check_output in 2.7.


You can pass shell=True if you want it too:

subprocess.check_output("ls -al", shell=True)

Note the possible resulting security vulnerabilities.


Yes, you're correct (it's been a while since I had to use that, should have checked, and I can't edit the comment).

os.popen() is still available in python3, and uses subprocess.Popen() internally.


That is certainly ugly, but sadly it's the option I prefer nowadays. In perl I use 3 argument open with a pipe instead of backticks. Especially if any of your args come from a variable--suddenly you have to think of shell quoting in your perl code. Yuck.

Perl desperately needs a built-in backtick() function:

    my $x = backtick(qw(my-program -l -V), "--option=$something", @files);
Maybe in perl you'd call it ``() or something instead of backtick().


You can do that quite cleanly in Python:

import commands print commands.getoutput("your system call and args")


You picked an example where Python took a step backwards in readability. That's fair but surely not typical. I agree it was a loss since I'm a huge fan of language usability-- in Python 2.5 os.popen is really rather simple to read and use.


shells were specifically made to operate with external programs (the Unix way) while Python is a more general programming language, so naturally it will be more verbose for this kind of task.

Of course the first syntax breaks when one of the arguments has a space or any other meta-character in it.


I'm fully aware of the reasons why things are as they are, and what the limitations of the different solutions are. My point still stands though, just because something is Python, written in the One True Way, does not guarantee readability.

To be absolutely clear, I actually like Python. I just strongly disagree with the belief that Python magically ensures readability. Particularly because my impression is that people who think that Python magic pixie dust automatically makes for good code are actually more likely to write bad code. (Because they have not thought deeply enough about what makes code good.)


Of course Python doesn't automatically ensure good code. But the Python code in your example is readable -- pretty match as readable as it gets, considering the constraints I mentioned.


I still disbelieve. Ruby is as much a general programming language as Python, yet supports a syntax that I find much more readable. I even find the deprecated os.popen interface in Python to be more readable than the official Python 2.6 interface. And, of course, the Python 2.7 syntax is better.

Therefore I can't agree that the Python that I presented is as good as is possible for a general purpose programming language.


I'd have to disagree. In this case, the backticks are quite idiomatic, whereas the Python is less so.

The Python example can be broken down by someone who knows OOP concepts in general, but not Python. It says:

Invoke function Popen on the object subprocess, giving the arguments (for example) 'ls' and '-al' in a list. Standard output should be handled in some way that is indicated by the value of PIPE. On the object returned from Popen, call communicate(), which returns an array; take the first element off that returned array.

Now, in order to make sense of this you would need to know what the arguments to Popen are, what communicate() means and what it returns.

Does that require a trip to the documentation? Yes. Is it less readable? No, it's more readable. The understanding of what was read is not immediately conveyed, however.

The Ruby/Perl/Bash backticks mean nothing even if you have an OO background. Maybe if the command is 'ls' and you know some Unix, you can work it out in your head to understand that it's invoking a command in the shell. What if it's calling something obscure with a string of arcane arguments appended? That will tell nothing, and the backticks will also add zero information.

Backticks are more convenient, but readability is the ability of someone who doesn't know that particular concept, or even that language, to still parse a statement and extract some level of understanding.


Disagree with which? That the Python version is as readable as it could be? Don't argue that with me, argue with the decision to add a utility method that makes Python 2.7 better.

As for readability, I emphatically disagree with you on how it should be defined. Readability is the result of the interaction between the programmer and the code. The interaction cannot be left out of this. There is such a thing as well-written, readable Greek. But if you don't speak Greek, it will all be Greek to you. COBOL was designed to be readable. Can you read any significant COBOL program? Old FORTRAN programmers complained that Smalltalk hideously unreadable because they didn't understand the basic concepts of OO.

That said, something that is long and full of moving parts is inherently a challenge to read. Even if you understand every piece of that Python example (I happen to), when you encounter it in code there is a lot of semantic noise to what is written. That complexity can and should be hidden. As the Python 2.7 API does.


I think you've mistaken my argument. I didn't say that the Python version looks good or is the best way to do it. It's not.

I was saying that "something that is long and full of moving parts" is easier to read than something that is short and idiomatic. I am not saying either of them represent the ideal way to do it.

My definition of readability includes the ability to convey the programmer's intention to the mind of the reader. The reader should be able to work out what is intended by the code with minimal requirements placed on them, and I think I detailed earlier why I think the Python code does a better job than simple surrounding a shell command with backticks.


The reader should be able to work out what is intended by the code with minimal requirements placed on them....

That's where the argument goes wrong, if the idea of "minimal requirements" means "avoid idioms".


Well, I'd welcome an explanation of your opinion here.


Unless I'm writing training material for novices, I write code with the assumption that anyone else maintaining it is reasonably competent with the languages, libraries, and tools in question. That to me is a minimal requirement.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: